Add check for parameter yaml to ensure consistence with source#7592
Open
Cstandardlib wants to merge 7 commits into
Open
Add check for parameter yaml to ensure consistence with source#7592Cstandardlib wants to merge 7 commits into
Cstandardlib wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses #7590 by adding a CI guardrail that verifies the committed docs/parameters.yaml matches the parameter metadata embedded in the C++ source, preventing the docs from drifting when INPUT parameters change.
Changes:
- Adds a GitHub Actions step that runs
abacus_* --generate-parameters-yamland diffs the output againstdocs/parameters.yaml. - Emits a clear failure message with regeneration instructions and prints a diff on mismatch.
|
How about adding it to "Integration test" instead? |
Collaborator
Author
Thanks, I will add it to an integration test. |
mohanchen
added
the
Compile & CICD & Docs & Dependencies
mohanchen
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #7590
What's changed?